Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl : support alter table xx nocache operations switch a table into uncacheable #29621

Merged
merged 12 commits into from
Nov 11, 2021
Merged

ddl : support alter table xx nocache operations switch a table into uncacheable #29621

merged 12 commits into from
Nov 11, 2021

Conversation

JayLZhou
Copy link
Contributor

@JayLZhou JayLZhou commented Nov 9, 2021 •
edited by tiancaiamao
Loading

What problem does this PR solve?

handle DDL schema changes when a table is set to uncachable , we use synatxalter table xx nocache to switch a cacheable table to uncachable table.

Issue number: close #29645

Problem Summary:

This is a subtask in #25293

What is changed and how it works?

support switch a cachable table to uncachable operation. and do some compatibility check with other feature.
ALTER TABLE t NOCACHE is a DDL operation. for consistency under distributed conditions. an intermediate Switching state is introduced, the schema change process is similar to the table lock implementation:
Enabled => Switching => Disabled

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2021
@JayLZhou JayLZhou changed the title Ddl uncache ddl : support alter table xx nocache operations Nov 9, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@JayLZhou JayLZhou changed the title ddl : support alter table xx nocache operations ddl : support alter table xx nocache operations Nov 9, 2021
@JayLZhou JayLZhou changed the title ddl : support alter table xx nocache operations ddl : support alter table xx nocache operations switch a table into uncacheable Nov 9, 2021
@JayLZhou
Copy link
Contributor Author

JayLZhou commented Nov 9, 2021

/run-check_title

@JayLZhou
Copy link
Contributor Author

JayLZhou commented Nov 9, 2021

/cc @tiancaiamao @lcwangchao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 89845df

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@JayLZhou
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@JayLZhou
Copy link
Contributor Author

/run-check_dev_2

tangenta
tangenta reviewed Nov 10, 2021
View reviewed changes
ddl/table_test.go Outdated Show resolved Hide resolved
@JayLZhou @tangenta
Update ddl/table_test.go
4cb5a70 
Co-authored-by: tangenta <tangenta@126.com>
@JayLZhou
Copy link
Contributor Author

/run-check_dev_2

@JayLZhou
Copy link
Contributor Author

/run-check_dev_2

hawkingrei
hawkingrei reviewed Nov 11, 2021
View reviewed changes
ddl/db_cache_test.go Outdated
tk2 := testkit.NewTestKit(c, s.store)
tk.MustExec("use test")
tk.MustExec("drop table if exists nocache_t1")
tk2.MustExec("use test")
Copy link
Member

@hawkingrei hawkingrei Nov 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tk2 just do one thing？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. don't need tk2 here.

@JayLZhou
Copy link
Contributor Author

JayLZhou commented Nov 11, 2021 •
edited
Loading

My pr encountered ci. Already resolved in this pr #29443

@ti-chi-bot
Copy link
Member

@hawkingrei: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@jayl-zxl: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a237e41 into pingcap:master Nov 11, 2021
@JayLZhou JayLZhou deleted the ddl_uncache branch November 11, 2021 09:23
@tiancaiamao tiancaiamao mentioned this pull request Nov 15, 2021
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support alter table xxx nocache operation
7 participants
@JayLZhou @ti-chi-bot @sre-bot @tiancaiamao @lcwangchao @hawkingrei @tangenta