Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support multi bracket for subquery #29656

Merged
merged 14 commits into from
Dec 2, 2021
Merged

parser: support multi bracket for subquery #29656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5826d0d
encounter s/r conflict
sylzd Nov 10, 2021
346d736
complete
sylzd Nov 30, 2021
21fea3a
fix
sylzd Nov 30, 2021
57150ef
fix parser conflict
sylzd Nov 30, 2021
d86f338
add original test case
sylzd Nov 30, 2021
94018d4
make parser fmt
sylzd Nov 30, 2021
5b5e029
add 2 more cases
sylzd Nov 30, 2021
b658bbc
add anno
sylzd Nov 30, 2021
687c2f3
fix anno
sylzd Nov 30, 2021
f317c9c
add test case for binding
sylzd Dec 1, 2021
93d5f2c
Merge branch 'master' into issue_29416
sylzd Dec 1, 2021
b8b3897
Merge branch 'master' into issue_29416
sylzd Dec 1, 2021
846ea50
Merge branch 'master' into issue_29416
ti-chi-bot Dec 2, 2021
e550331
Merge branch 'master' into issue_29416
ti-chi-bot Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bindinfo/bind_serial_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,22 @@ func TestBindingWithoutCharset(t *testing.T) {
require.Equal(t, "SELECT * FROM `test`.`t` WHERE `a` = 'aa'", rows[0][1])
}

func TestBindingWithMultiParenthesis(t *testing.T) {
store, clean := testkit.CreateMockStore(t)
defer clean()

tk := testkit.NewTestKit(t, store)
tk.MustExec("use test")
tk.MustExec("drop table if exists t")
tk.MustExec("create table t (a int)")
tk.MustExec("create global binding for select * from (select * from t where a = 1) tt using select * from (select * from t where a = 1) tt")
tk.MustExec("create global binding for select * from ((select * from t where a = 1)) tt using select * from (select * from t where a = 1) tt")
rows := tk.MustQuery("show global bindings").Rows()
require.Len(t, rows, 1)
require.Equal(t, "select * from ( select * from `test` . `t` where `a` = ? ) as `tt`", rows[0][0])
require.Equal(t, "SELECT * FROM (SELECT * FROM `test`.`t` WHERE `a` = 1) AS `tt`", rows[0][1])
}

func TestGCBindRecord(t *testing.T) {
// set lease for gc tests
originLease := bindinfo.Lease
Expand Down
Loading