-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix topn wrongly pushed to index scan side when it's a prefix index (#29778) #29800
planner: fix topn wrongly pushed to index scan side when it's a prefix index (#29778) #29800
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@time-and-fate you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5f11522
|
cherry-pick #29778 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/29800
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #29711
Problem Summary:
When the
IndexScan
is using a prefix index, and theTopN.ByItems
used the prefix column, theTopN
is wrongly pushed toindexPlan
.What is changed and how it works?
Check and push
TopN
totablePlan
in the above case.Check List
Tests
Side effects
Documentation
Release note