-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix drop role failed after revoke role from current user #29814
Conversation
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
Although it still fails on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have a few questions :)
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reporting the new bug too!
/merge |
This pull request has been accepted and is ready to merge. Commit hash: fa04b39
|
Signed-off-by: unconsolable chenzhipeng2012@gmail.com
What problem does this PR solve?
Issue Number: close #29781
Problem Summary:
What is changed and how it works?
Seems a follow-up of #29494
Check List
Tests
Side effects
Documentation
Release note