Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin: add builtin function 'TO_DAYS' #2983

Merged
merged 12 commits into from
Apr 7, 2017
Merged

Builtin: add builtin function 'TO_DAYS' #2983

merged 12 commits into from
Apr 7, 2017

Conversation

spongedu
Copy link
Contributor

Add implementation for builtin function 'TO_DAYS'

@spongedu spongedu mentioned this pull request Mar 31, 2017
Closed
@coocood coocood added the contribution This PR is from a community contributor. label Mar 31, 2017
@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 5, 2017
zimulala
zimulala reviewed Apr 5, 2017
View reviewed changes
expression/builtin_time_test.go Outdated
c.Assert(err, IsNil)
c.Assert(d.IsNull(), IsTrue)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this useless line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 6, 2017

LGTM

@zimulala
Copy link
Contributor

zimulala commented Apr 6, 2017

Please fix conflicting.

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2017
@zimulala zimulala merged commit 445116a into pingcap:master Apr 7, 2017
@spongedu spongedu deleted the builtin_to_days branch April 7, 2017 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spongedu @tiancaiamao @XuHuaiyu @zimulala @coocood