Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix wrong result type for greatest/least (#29408) #29914

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 18, 2021

cherry-pick #29408 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29914

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29914:release-5.2-4b110036e1a7

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #29019

Problem Summary:

  1. When all arguments types for greatest/least are datetime, we deduce the result type as string incorrectly.

What's changed:

  1. So we need to add four new function sigs for duration and time(builtinGreatestDurationSig, builtinGreatestTimeSig, builtinLeastDurationSig, builtinLeastTimeSig).
  2. Also we change the original sig to builtinGreatestCmpStringAsDatetime/builtinLeastCmpStringAsDatetime, because the original sig name is not reasonable.

TODO:

  1. When arguments of greatest/least are mixed with time, duration, string, the result is not compitable with mysql. Such as select least(cast('-800:10:10' as time), cast('2021-10-10 10:10:10.1234' as datetime), '99999999999') from t1;

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix wrong result type for greatest/least

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2021
@ti-srebot ti-srebot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 18, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 18, 2021
@ti-srebot
Copy link
Contributor Author

@guo-shaoge you're already a collaborator in bot's repo.

@wshwsh12 wshwsh12 removed their request for review January 11, 2022 07:05
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Apr 15, 2022
@guo-shaoge
Copy link
Collaborator

Also need to merge #31160 ,otherwise may introduce new problem #29019 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants