Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix bug https://asktug.com/t/topic/213082/11 (#29577) #30047

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 23, 2021

cherry-pick #29577 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30047

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30047:release-5.3-0f86a53d419c

What problem does this PR solve?

Issue Number: close #29709

See also https://asktug.com/t/topic/213082/11

Problem Summary:

Too much logs about auth plugin after upgrade tidb v5.2.2
[WARN] [conn.go:698] [“failed to check the user authplugin”] [conn=599967] [error=“Failed to get user record”]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

- Fix the bug that TiDB logs many `failed to check the user authplugin` when a user connects to TiDB.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 23, 2021
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.3-cherry-pick labels Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

@djshow832 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 23, 2021
dveeden added a commit to ti-srebot/tidb that referenced this pull request Nov 29, 2021
@guo-shaoge
Copy link
Collaborator

/run-check_dev

@guo-shaoge
Copy link
Collaborator

/run-myisql-test

@dveeden
Copy link
Contributor

dveeden commented Feb 15, 2022

/run-check_dev

@guo-shaoge
Copy link
Collaborator

Looks like #30450 already fixed.

@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2022
@dveeden
Copy link
Contributor

dveeden commented Mar 21, 2022

Looks like #30450 already fixed.

Yes looks like most (if not all) of this already made it to release-5.3.

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jun 16, 2022
@ti-chi-bot ti-chi-bot closed this Dec 1, 2023
@ti-chi-bot
Copy link
Member

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants