Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: let ignore columns be compatible with tidb backend (#27850) #30064

Merged
merged 9 commits into from
Feb 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 23, 2021

cherry-pick #27850 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30064

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30064:release-5.3-c68791566d55

What problem does this PR solve?

Let lightning config mydumper.ignore-columns be compatible with tidb backend.

Issue Number: ref #32591

Problem Summary:

What is changed and how it works?

Let the kv packend generated by encodeLoop contains the column names with ignore columns filtered instead of the raw column names.

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.3-cherry-pick labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 23, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

@glorv you're already a collaborator in bot's repo.

br/pkg/lightning/backend/tidb/tidb_test.go Outdated Show resolved Hide resolved
br/pkg/lightning/backend/tidb/tidb_test.go Outdated Show resolved Hide resolved
br/pkg/lightning/backend/tidb/tidb_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2021
@sleepymole
Copy link
Contributor

/run-check_dev

@sleepymole
Copy link
Contributor

[2021-11-25T02:54:11.317Z] PANIC: restore_test.go:1451: chunkRestoreSuite.TestEncodeLoopColumnsMismatch
[2021-11-25T02:54:11.317Z]
[2021-11-25T02:54:11.317Z] ... Panic: runtime error: index out of range [0] with length 0 (PC=0x1348FD8)

🤔

@glorv
Copy link
Contributor

glorv commented Nov 25, 2021

/run-check_dev

2 similar comments
@glorv
Copy link
Contributor

glorv commented Nov 25, 2021

/run-check_dev

@sleepymole
Copy link
Contributor

/run-check_dev

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2022
@glorv
Copy link
Contributor

glorv commented Feb 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88a430f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@ti-chi-bot ti-chi-bot merged commit 4d1f787 into pingcap:release-5.3 Feb 22, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
@glorv glorv deleted the release-5.3-c68791566d55 branch February 24, 2022 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants