Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: rebuild range when the range is empty (#30003) #30146

Merged
merged 13 commits into from
Feb 23, 2022
Merged

planner: rebuild range when the range is empty (#30003) #30146

merged 13 commits into from
Feb 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 25, 2021 •
edited
Loading

cherry-pick #30003 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30146

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30146:release-5.3-78c653e294e7

What problem does this PR solve?

Issue Number: close #29993
close #30100

Problem Summary:

  1. Do not check whether the range is empty.
  2. Do not generate tableDual plan.

What is changed and how it works?

  1. Check the length of the range.
  2. Generate the tableDual and uncache the plan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent @ti-srebot
cherry pick pingcap#30003 to release-5.3
9007a5a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 25, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 25, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 25, 2021
Merged
12 tasks
@ti-srebot ti-srebot added epic/plan-cache sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick type/bugfix This PR fixes a bug. labels Nov 25, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2021
@ti-srebot
Copy link
Contributor Author

@Reminiscent you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

/run-check_dev
@Reminiscent please remember to continue this work. A new version is about to release. Thanks!

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 16, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 16, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 22, 2022
@guo-shaoge
Copy link
Collaborator

/run-check_dev

@guo-shaoge
Copy link
Collaborator

/run-mysql-test

@guo-shaoge
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48fbefe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@Reminiscent
Copy link
Contributor

/run-check_dev

2 similar comments
@Reminiscent
Copy link
Contributor

/run-check_dev

@Reminiscent
Copy link
Contributor

/run-check_dev

@Reminiscent
Copy link
Contributor

/run-check_dev

@Reminiscent
Copy link
Contributor

/run-check_dev

@Reminiscent
Copy link
Contributor

/run-check_dev

1 similar comment
@Reminiscent
Copy link
Contributor

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit efa86e2 into pingcap:release-5.3 Feb 23, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees

@Reminiscent Reminiscent

Labels
cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @guo-shaoge @Reminiscent @qw4990 @rebelice @VelocityLight @purelind