Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: only wrap *_binary() builtin functions in new charset #30216

Closed
wants to merge 4 commits into from

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Related to #30156.

Problem Summary:

drop table if exists t;
CREATE TABLE t (a CHAR(5) CHARACTER SET latin1);
INSERT INTO t VALUES (0xf6);
select * from t;
SELECT HEX(a) FROM t WHERE a= 0xf6;

In old version TiDB:

mysql> select * from t;
+------+
| a    |
+------+
| �     |
+------+
1 row in set (0.00 sec)

mysql> SELECT HEX(a) FROM t WHERE a= 0xf6;
+--------+
| HEX(a) |
+--------+
| F6     |
+--------+

In TiDB master:

mysql> select * from t;
+------+
| a    |
+------+
| �     |
+------+
1 row in set (0.00 sec)

mysql> SELECT HEX(a) FROM t WHERE a= 0xf6;
Empty set (0.01 sec)

Latin1 character set behavior should be consistent with the old version TiDB.

What is changed and how it works?

Only wrap from_binary() and to_binary() for the arguments with new charset.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 29, 2021
@ti-chi-bot
Copy link
Member

@tangenta: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor Author

tangenta commented Dec 7, 2021

The test will be added by #30288.

@tangenta tangenta closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants