-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: support both gs and gcs in url #30254
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bb3c2ca
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ab144ee6840f5c01babee4fa9037ebb2dbc04054 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #31168 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.3 in PR #31169 |
What problem does this PR solve?
Issue Number: close #32742
Problem Summary:
Lightning will result in error if the storage url is "gs://xxx" instead of "gcs://xxx" but the original storage package support both of them, lightning pre-check should be compitible with both.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note