Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, ddl: convert large varchar for create table in non strict mode #30348

Closed
wants to merge 2 commits into from
Closed

planner, ddl: convert large varchar for create table in non strict mode #30348

wants to merge 2 commits into from

Conversation

unconsolable
Copy link
Contributor

@unconsolable unconsolable commented Dec 2, 2021 •
edited
Loading

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #30328

Problem Summary:

What is changed and how it works?

  • In non strict mode, auto convert varchar with large length to TEXT or BLOB, and append warnings.
  • Fix a nil pointer dereference in test case due to changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sylzd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2021
@unconsolable
planner, ddl: convert large varchar for create table in non strict mode
faa44c7 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@unconsolable unconsolable marked this pull request as ready for review December 2, 2021 11:03
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2021
@unconsolable
Copy link
Contributor Author

/cc @djshow832 @tangenta
PTAL, thanks

@unconsolable
add warning test
bdc8e97 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2021
@unconsolable
Copy link
Contributor Author

/cc @bb7133
PTAL, thanks

@ti-chi-bot ti-chi-bot requested a review from bb7133 December 8, 2021 01:06
@unconsolable unconsolable deleted the issue-30328 branch December 20, 2021 11:25
@unconsolable
Copy link
Contributor Author

I haven't take a look of this PR for a while. I found that it has some other problems with current code, but I don't have time to fix it now....

@djshow832
Copy link
Contributor

@unconsolable Sorry that I missed the message. Which kind of problem did you meet? Code conflicts or bugs?

@unconsolable
Copy link
Contributor Author

@unconsolable Sorry that I missed the message. Which kind of problem did you meet? Code conflicts or bugs?

It fails on some other tests, I was a bit busy at that time, and I can't take time on fixing it, so I closed the issue and unassigned myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylzd sylzd sylzd approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@djshow832 djshow832 Awaiting requested review from djshow832

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
4 participants
@unconsolable @ti-chi-bot @djshow832 @sylzd