Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, util: reset offsets and nullBitMap for MutRow when setting new values (#30265) #30391

Merged
merged 14 commits into from
Apr 15, 2022
Merged

executor, util: reset offsets and nullBitMap for MutRow when setting new values (#30265) #30391

merged 14 commits into from
Apr 15, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 3, 2021 •
edited
Loading

cherry-pick #30265 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30391

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30391:release-5.2-70d29735e636

What problem does this PR solve?

Issue Number: close #29947

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Side effects

N/A

Documentation

N/A

Release note

Fix the problem that window function may return different results when using transaction or not.

@XuHuaiyu @ti-srebot
cherry pick pingcap#30265 to release-5.2
ee9e638 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2021
@ti-srebot ti-srebot added component/executor size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 3, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Merged
2 tasks
@ti-srebot ti-srebot added this to the v5.2.2 milestone Dec 3, 2021
@ti-srebot
Copy link
Contributor Author

@XuHuaiyu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2021
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ee9e638

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3092692

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-mysql-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a228cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8331741f0d70e3157d99334ac278e4fb710fa78c

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-mysql-test

@winoros
Copy link
Member

winoros commented Apr 15, 2022

/run-mysql-test tidb-test=pr/1663

@winoros
Copy link
Member

winoros commented Apr 15, 2022

@ti-chi-bot

@ti-chi-bot ti-chi-bot merged commit d085522 into pingcap:release-5.2 Apr 15, 2022
@winoros winoros deleted the release-5.2-70d29735e636 branch April 15, 2022 09:26
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.2, v5.2.4 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@winoros winoros winoros approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees

@XuHuaiyu XuHuaiyu

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/executor release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @winoros @XuHuaiyu @sre-bot @wshwsh12 @VelocityLight @zhouqiang-cl