executor/split_test.go: migrate test-infra to testify #30485

zach030 · 2021-12-07T09:16:17Z

What problem does this PR solve?

Issue Number: close #28617

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2021-12-07T09:16:18Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

hawkingrei
tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

tangenta

Could you please make these tests run in parallel by adding t.Parallel()?

zach030 · 2021-12-10T16:09:46Z

Ok! I will add it.

executor/split_test.go

hawkingrei · 2021-12-11T05:25:35Z

#30267

There is an example of migration.

executor/split_test.go

hawkingrei · 2021-12-11T16:31:04Z

After fixed, Please @me or join in tidb slack channel to find me.

zach030 · 2021-12-11T17:34:17Z

After fixed, Please @me or join in tidb slack channel to find me.

Thx, I have fixed it.

executor/split_test.go

hawkingrei · 2021-12-13T03:50:14Z

Please run make fmt in the project root directory to fix linter.

executor/split_test.go

zach030 · 2021-12-13T13:34:49Z

Please run make fmt in the project root directory to fix linter.

Thanks! please review again

executor/split_test.go

tangenta · 2021-12-23T09:37:21Z

@zach030 Here are some backgrounds about the CI tests. It explains why we move to the serial way, FYI.

Co-authored-by: tangenta <tangenta@126.com>

zach030 · 2021-12-24T03:08:06Z

already done

ti-chi-bot · 2021-12-25T10:50:12Z

@zach030: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

executor/split_test.go

hawkingrei · 2021-12-25T14:00:37Z

executor/split_test.go

-	c.Assert(err, IsNil)
-	c.Assert(len(valueList), Equals, e.num+1)
+	require.NoError(t, err)
+	require.Len(t, len(valueList), e.num+1)


Signed-off-by: zach <zachchou016@gmail.com>

…fix_issue_28617

sre-bot · 2021-12-25T14:30:16Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f2b90627d28ac1e1a25143312c8d39daec91e57

zach030 · 2021-12-28T12:03:42Z

@hawkingrei can we merge now

tiancaiamao · 2021-12-29T01:29:28Z

/merge

ti-chi-bot · 2021-12-29T01:29:31Z

This pull request has been accepted and is ready to merge.

Commit hash: d440900

ti-chi-bot · 2021-12-29T03:55:59Z

@zach030: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

executor/split_test.go: migrate test-infra to testify

945d61e

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021

executor/split_test.go: execute go fmt

409f7f4

tangenta reviewed Dec 10, 2021

View reviewed changes

executor/split_test.go: add parallel for test

85d4d82

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021

tangenta approved these changes Dec 11, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2021

tangenta requested a review from hawkingrei December 11, 2021 03:39

tangenta reviewed Dec 11, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

hawkingrei reviewed Dec 11, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

executor/split_test.go Outdated Show resolved Hide resolved

executor: replace assert with require

3ef8aba

ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2021

hawkingrei reviewed Dec 11, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

executor/split_test.go Outdated Show resolved Hide resolved

executor/split_test.go Outdated Show resolved Hide resolved

executor/split_test.go Outdated Show resolved Hide resolved

executor: replace nil with no-error

ff21d86

tangenta reviewed Dec 13, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

tangenta requested a review from hawkingrei December 13, 2021 03:05

executor: remove format and go-fmt

a0cb567

hawkingrei reviewed Dec 13, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

hawkingrei reviewed Dec 13, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

tangenta reviewed Dec 23, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

tangenta reviewed Dec 23, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

tangenta reviewed Dec 23, 2021

View reviewed changes

executor/split_test.go Outdated Show resolved Hide resolved

zach030 and others added 5 commits December 23, 2021 21:34

Update executor/split_test.go

9e2c82c

Co-authored-by: tangenta <tangenta@126.com>

Update executor/split_test.go

0993e35

Co-authored-by: tangenta <tangenta@126.com>

Update executor/split_test.go

47837db

Co-authored-by: tangenta <tangenta@126.com>

Update executor/split_test.go

811a8e9

Co-authored-by: tangenta <tangenta@126.com>

Update executor/split_test.go

9b4d1e4

Co-authored-by: tangenta <tangenta@126.com>

Merge branch 'master' into zq_fix_issue_28617

1deafb1

hawkingrei approved these changes Dec 25, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2021

Merge branch 'master' into zq_fix_issue_28617

f848c00

hawkingrei reviewed Dec 25, 2021

View reviewed changes

hawkingrei self-requested a review December 25, 2021 14:01

zach030 added 2 commits December 25, 2021 22:06

executor/split.go:fix require len

d07b9f9

Signed-off-by: zach <zachchou016@gmail.com>

Merge branch 'zq_fix_issue_28617' of github.com:zach030/tidb into zq_…

d440900

…fix_issue_28617

hawkingrei approved these changes Dec 29, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2021

ti-chi-bot added 2 commits December 29, 2021 09:29

Merge branch 'master' into zq_fix_issue_28617

6cb86ba

Merge branch 'master' into zq_fix_issue_28617

4f2b906

ti-chi-bot merged commit 8193c46 into pingcap:master Dec 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

executor/split_test.go: migrate test-infra to testify #30485

executor/split_test.go: migrate test-infra to testify #30485

zach030 commented Dec 7, 2021

ti-chi-bot commented Dec 7, 2021 •

edited

Loading

tangenta left a comment

zach030 commented Dec 10, 2021

hawkingrei commented Dec 11, 2021

hawkingrei commented Dec 11, 2021

zach030 commented Dec 11, 2021

hawkingrei commented Dec 13, 2021

zach030 commented Dec 13, 2021

tangenta commented Dec 23, 2021

zach030 commented Dec 24, 2021

ti-chi-bot commented Dec 25, 2021

hawkingrei Dec 25, 2021

sre-bot commented Dec 25, 2021 •

edited

Loading

zach030 commented Dec 28, 2021

tiancaiamao commented Dec 29, 2021

ti-chi-bot commented Dec 29, 2021

ti-chi-bot commented Dec 29, 2021

executor/split_test.go: migrate test-infra to testify #30485

executor/split_test.go: migrate test-infra to testify #30485

Conversation

zach030 commented Dec 7, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 7, 2021 • edited Loading

tangenta left a comment

Choose a reason for hiding this comment

zach030 commented Dec 10, 2021

hawkingrei commented Dec 11, 2021

hawkingrei commented Dec 11, 2021

zach030 commented Dec 11, 2021

hawkingrei commented Dec 13, 2021

zach030 commented Dec 13, 2021

tangenta commented Dec 23, 2021

zach030 commented Dec 24, 2021

ti-chi-bot commented Dec 25, 2021

hawkingrei Dec 25, 2021

Choose a reason for hiding this comment

sre-bot commented Dec 25, 2021 • edited Loading

zach030 commented Dec 28, 2021

tiancaiamao commented Dec 29, 2021

ti-chi-bot commented Dec 29, 2021

ti-chi-bot commented Dec 29, 2021

ti-chi-bot commented Dec 7, 2021 •

edited

Loading

sre-bot commented Dec 25, 2021 •

edited

Loading