-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,util: write slow query to slow log no matter what log level (#30461) #30493
executor,util: write slow query to slow log no matter what log level (#30461) #30493
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@TonsnakeLin please accept the invitation then you can push to the cherry-pick pull requests. Comment with |
/run-mysql-test |
/run-mysql-test |
/run-check_dev |
1 similar comment
/run-check_dev |
/merge |
@TonsnakeLin: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 78dc9b6
|
/run-check_dev |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-check_dev |
1 similar comment
/run-check_dev |
/run-mysql-test |
1 similar comment
/run-mysql-test |
/run-mysql-test |
/run-check_dev |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev |
cherry-pick #30461 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30493
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #30309
Problem Summary:
What is changed and how it works?
The slow log uses the default log level that is info level.
Executor writes slow query by log.WARN methods
Check List
Tests
Side effects
Documentation
Release note