-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: migrate test-infra to testify for slow_query_test.go #30521
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
6c83008
to
edc66fc
Compare
/run-check_dev |
/run-check_dev_2 |
Signed-off-by: Shenjun <mashenjun0902@gmail.com>
a0523ed
to
90b5482
Compare
Signed-off-by: Shenjun <mashenjun0902@gmail.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/24c60f067adcf10231a2217a0b437f9f97b6616d |
/run-check_dev_2 |
@tangenta PTAL |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b6b98ed
|
@mashenjun: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Shenjun mashenjun0902@gmail.com
What problem does this PR solve?
Issue Number: close #28615
Problem Summary: replace
pingcap/check
withstretchr/testify
inslow_query_test.go
What is changed and how it works?
use testify in test case under
slow_query_test.go
Check List
Tests
Side effects
Documentation
Release note