fix:impl builtin:func to_base64 & fix from_base64 bug #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**the mysql required: Decoding recognizes and ignores newline, carriage return, tab, and space. the go base64 DecodeString() doesn't ignore tab ,space** ----- Also I impl builtin:func to_base64()
This was referenced Apr 14, 2017
tiancaiamao
reviewed
Apr 17, 2017
| @@ -1795,7 +1797,46 @@ type builtinToBase64Sig struct { | |||
|
|
|||
| // See https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_to-base64 | |||
| func (b *builtinToBase64Sig) eval(row []types.Datum) (d types.Datum, err error) { | |||
| return d, errFunctionNotExists.GenByArgs("TO_BASE64") | |||
| //return d, errFunctionNotExists.GenByArgs("TO_BASE64") | |||
There was a problem hiding this comment.
remove useless comment
| } | ||
|
|
||
| //func to splite a string every n runes into a string[] | ||
| func splitToSubN(s string, n int) []string { |
There was a problem hiding this comment.
After base64 encoding, all characters should never be UTF8 runes, so we can make this function simpler:
func splitToSubN(s string, n int) []string {
subs := make([]string, 0, len(s)/n + 1)
for len(s) > n {
subs = append(subs, s[:n])
s = s[n:]
}
subs = append(subs, s)
return subs
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql required:
But go base64 func DecodeString() doesn't ignore tab ,space.
select from_base64("YW Jj");
ERROR 1105 (HY000): illegal base64 data at input byte 2
select from_base64("YW Jj");
+-----------------------+
| from_base64("YW Jj") |
+-----------------------+
| abc |
+-----------------------+
So I fix it && also I impl builtin:func to_base64(). I also add more test cases.