-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: Add source dir existence check for s3 (#30674) #30713
lightning: Add source dir existence check for s3 (#30674) #30713
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@glorv you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3856bbc
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0b7d465aa5b00baeb624f19dc9faeb7e64476b32 |
cherry-pick #30674 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30713
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28031, close #30709
Problem Summary:
What is changed and how it works?
WalkDir
after build remote storage to check whether target directory contains at least one regular file.skip-check-path
parameter for br and lightning because the requirement privilege is too high.Check List
Tests
Side effects
Documentation
Release note