Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topsql: add pubsub datasink #30827

Closed
wants to merge 1 commit into from
Closed

topsql: add pubsub datasink #30827

wants to merge 1 commit into from

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Dec 17, 2021 •
edited
Loading

What problem does this PR solve?

Part of #29020

Problem Summary:

Make the diagnostic node dependent on TiDB instead of TiDB dependent on the diagnostic node to reverse the dependency to a normal form.

What is changed and how it works?

Implement pubsub datasink.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

topsql: introduce pubsub mode

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@zhongzc zhongzc requested a review from a team as a code owner December 17, 2021 03:56
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 17, 2021
@zhongzc
topsql: add pubsub datasink
4c9cdbf 
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
@zhongzc zhongzc force-pushed the topsql-pubsub-datasink branch from 96daf71 to 4c9cdbf Compare December 20, 2021 02:25
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Dec 20, 2021
@zhongzc zhongzc closed this Dec 20, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2021

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4c9cdbf0e225ab43f76bf591dd9df0e880404542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongzc @ti-chi-bot @sre-bot