Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix load data panic if the data is broken at escape character #30868

Merged
merged 11 commits into from
Jan 18, 2022
Merged

executor: fix load data panic if the data is broken at escape character #30868

merged 11 commits into from
Jan 18, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Dec 20, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31589

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

fix load data will panic in some case

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 20, 2021
@xiongjiwei
Copy link
Contributor Author

/run-build comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Dec 20, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f0073e51bc759ab99e0ecc2dbd51b8e82936265f

@xiongjiwei xiongjiwei closed this Dec 20, 2021
@xiongjiwei xiongjiwei reopened this Dec 21, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2021
youjiali1995
youjiali1995 previously approved these changes Dec 21, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

youjiali1995
youjiali1995 reviewed Dec 22, 2021
View reviewed changes
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 12, 2022
@xiongjiwei xiongjiwei changed the title [DNM]load data: log executor: fix load data panic if the data is broken at escape character Jan 12, 2022
youjiali1995
youjiali1995 reviewed Jan 13, 2022
View reviewed changes
executor/load_data.go Show resolved Hide resolved
executor/load_data.go Show resolved Hide resolved
executor/load_data.go Show resolved Hide resolved
executor/load_data.go Outdated Show resolved Hide resolved
@xiongjiwei
Copy link
Contributor Author

/cc @cfzjywxk @zimulala
PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2022
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa23b1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@xiongjiwei xiongjiwei added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Jan 18, 2022
@ti-chi-bot ti-chi-bot merged commit 6536562 into pingcap:master Jan 18, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 18, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#30868 to release-5.3
1c22d2e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 18, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31773

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 18, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#30868 to release-5.4
6167ff8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 18, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31774

ti-chi-bot pushed a commit that referenced this pull request Mar 2, 2022
@ti-srebot
executor: fix load data panic if the data is broken at escape charact…
459917c 
…er (#30868) (#31773)

close #31589
zhouqiang-cl pushed a commit that referenced this pull request Mar 8, 2022
@xiongjiwei
cherry pick #30868 to release-5.4 (#32892)
4865a0f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Mar 8, 2022
@ti-srebot
executor: fix load data panic if the data is broken at escape charact…
6ccbcef 
…er (#30868) (#31774)

close #31589
@xiongjiwei xiongjiwei deleted the load-data-log branch September 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@jackysp jackysp Awaiting requested review from jackysp

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

load data will panic if the content is break at escape character
7 participants
@xiongjiwei @ti-chi-bot @sre-bot @jackysp @ti-srebot @youjiali1995 @Defined2014