*: query failed after add index / timestamp out-of-range (#28424) (#29323)

[ti-srebot]

cherry-pick #29323 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30986

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30986:release-5.3-9d4da4f3fb05

---

What problem does this PR solve?

Issue Number: close #28424

Problem Summary: Timestamp out-of-range and range optimizer incompatibility.

What is changed and how it works?

Two issues, convertToMysqlTimestamp did set out-of-range timestamp to
Zero, when it would still be a storable/comparable KindMysqlTime.
(we only artificially limit the range of Timestamp to be compatible
with MySQL).

When this change was done,
it broke #26584 (insert of invalid timestamp succeeded),
which needed a different change in handleZeroDatetime

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fixed index handling bug with timestamp out-of-range.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• tiancaiamao
• xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-chi-bot]

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-srebot]

/run-all-tests

[ti-srebot]

@mjonss you're already a collaborator in bot's repo.

[xhebox]

/cc @mjonss do we still cherry-pick this and #30985?

[mjonss]

/cc @mjonss do we still cherry-pick this and #30985?

@xhebox Not sure, since #28424 is just minor.

@time-and-fate do you still want this cherry-picked to 5.2 and 5.3?

[guo-shaoge]

@mjonss Do we need to merge this to 5.3. Because a new version is about to release.

[VelocityLight]

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

• https://prow.tidb.io/command-help#cherrypick
• https://book.prow.tidb.net/#/plugins/cherrypicker

You can find more details at:

• https://internals.tidb.io/t/topic/785