-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix stmt summary nil pointer panic on the cached table #31079
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9de73b23f09fcacd33e4de0b982819a05fd9a956 |
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8232448
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
What problem does this PR solve?
Issue Number: close #31077
Problem Summary:
It's a bug introduced in https://github.com/pingcap/tidb/pull/30166/files#diff-cda21674d674295dde958bfdfe5d6ecd21ae07fd310fa907920e1214108d974fR1198
When there isn't any coprocessor request, the map is
nil
, so set the nil map cause panic.The old code comes with test, but the test doesn't really cover that line,
that's because there is a special judgement here, when
AuthUser
string is empty, the stmt summary code is skipped!tidb/executor/adapter.go
Line 1163 in 57b2908
What is changed and how it works?
Fix the nil pointer panic.
Check List
Tests
Side effects
Documentation
Release note