Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add variable tidb_placement_mode and remove placement_checks #31093

Merged
merged 29 commits into from
Jan 12, 2022
Merged

*: Add variable tidb_placement_mode and remove placement_checks #31093

merged 29 commits into from
Jan 12, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Dec 28, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31092

What is changed and how it works?

Introduce new variable tidb_placement_mode and it has two enums:

  • strict: The default value, check all placement settings in ddl operations
  • ignore: Ignore all placement settings in ddl operations

BR will use CreateTableWithInfo , CreateSchemaWithInfo to create table and database, so we must only valid placement policy in these methods. This PR moved checkAndNormalizePlacement from out into these methods.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

1. Remove sys variable `placement_checks`
2. Introduce new system variable `tidb_placement_mode`

@lcwangchao lcwangchao requested a review from a team as a code owner December 28, 2021 12:06
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 28, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 28, 2021
@morgo
Copy link
Contributor

morgo commented Dec 28, 2021

Can you remove the sysvar PLACEMENT_CHECKS in the same PR? This will help reduce the confusion.

@morgo morgo changed the title *: Add vairable tidb_placement_mode *: Add variable tidb_placement_mode Dec 28, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 28, 2021
djshow832
djshow832 reviewed Dec 30, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ddl/partition.go Outdated Show resolved Hide resolved
ddl/partition.go Outdated Show resolved Hide resolved
ddl/ddl_api.go Outdated Show resolved Hide resolved
lcwangchao and others added 2 commits December 31, 2021 11:37
@lcwangchao @djshow832
Update ddl/partition.go
1e08034 
Co-authored-by: djshow832 <zhangming@pingcap.com>
@lcwangchao @djshow832
Update ddl/ddl_api.go
1937bc9 
Co-authored-by: djshow832 <zhangming@pingcap.com>
@lcwangchao lcwangchao marked this pull request as draft December 31, 2021 03:54
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 31, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 11, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 08f75a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2022
@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-integration-test-mysql-5735

@lcwangchao
Copy link
Collaborator Author

/run-check_dev

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

/run-integration-test-mysql-5735

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-unit-test

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit d088e3d into pingcap:master Jan 12, 2022
@lcwangchao lcwangchao deleted the placement_mode branch January 12, 2022 05:06
@lcwangchao lcwangchao mentioned this pull request Jan 12, 2022
Merged
12 tasks
@lcwangchao lcwangchao linked an issue Jan 12, 2022 that may be closed by this pull request
BR restore table with a policy failed even if the target tidb already has a policy with the same name #31455
Closed
@morgo morgo mentioned this pull request Mar 16, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@xhebox xhebox xhebox approved these changes

@morgo morgo morgo approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@lcwangchao @ti-chi-bot @morgo @sre-bot @xhebox @djshow832