Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: use node.Restore() to add TiDB-specified feature comments #31148

Merged
merged 4 commits into from
Jan 3, 2022
Merged

binlog: use node.Restore() to add TiDB-specified feature comments #31148

merged 4 commits into from
Jan 3, 2022

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 29, 2021

What problem does this PR solve?

Issue Number: close #31147

What is changed and how it works?

As is described in the issue.

Check List

Tests

  • Unit test

Side effects

  • Performance regression: Consumes more CPU

Documentation

  • NA

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 29, 2021
@bb7133 bb7133 force-pushed the bb7133/i_31147 branch 3 times, most recently from cdb5869 to 6189490 Compare December 30, 2021 02:00
@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7a56a76641b0eb3d30c3c03d929041ae5d8e4f0b

@bb7133 bb7133 requested a review from tangenta December 30, 2021 06:45
@tangenta
Copy link
Contributor

I think we can remove the file types/parser_driver/special_cmt_ctrl.go.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2021
@bb7133
Copy link
Member Author

bb7133 commented Dec 30, 2021

@tangenta @Defined2014 PTAL again.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 30, 2021
Defined2014
Defined2014 requested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems have some problems with UT

@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Dec 30, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 2, 2022
@tangenta
Copy link
Contributor

tangenta commented Jan 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ead693f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 2, 2022
@ti-chi-bot
Copy link
Member

@bb7133: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Defined2014
Copy link
Contributor

/run-unit-test

@Defined2014
Copy link
Contributor

/run-mysql-test

@Defined2014
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 69e179e into pingcap:master Jan 3, 2022
@lichunzhu lichunzhu mentioned this pull request Jan 12, 2022
Closed
@bb7133 bb7133 deleted the bb7133/i_31147 branch December 12, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@tangenta tangenta tangenta approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

binlog: use node.Restore() to add TiDB-specified feature comments
6 participants
@bb7133 @ti-chi-bot @sre-bot @tangenta @Defined2014 @djshow832