Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx: fix wrong skipInit for tidb_enable_paging #31162

Merged
merged 4 commits into from
Dec 30, 2021

Conversation

you06
Copy link
Contributor

@you06 you06 commented Dec 30, 2021

Signed-off-by: you06 you1474600@gmail.com

What problem does this PR solve?

Issue Number: ref #30578

Problem Summary:

What is changed and how it works?

#30536 introduced tidb_enable_paging which is the switch of coprocessor paging. This PR fixes the wrong skipInit of that sysvar.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@you06 you06 requested a review from a team as a code owner December 30, 2021 03:54
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 30, 2021
@you06 you06 requested a review from youjiali1995 December 30, 2021 04:03
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2021
@youjiali1995 youjiali1995 requested a review from zyguan December 30, 2021 06:07
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 30, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2021

@you06
Copy link
Contributor Author

you06 commented Dec 30, 2021

@youjiali1995 can you help me merge this PR?

@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f4667d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2021
@you06
Copy link
Contributor Author

you06 commented Dec 30, 2021

/run-check_dev_2

@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@you06: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sticnarf
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 99ad750 into pingcap:master Dec 30, 2021
@you06 you06 deleted the fix-paging-sysvar branch December 30, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants