plan: new plan supports join. #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
reviewed
Apr 24, 2017
| case RightOuterJoin: | ||
| hashJoin.SmallTable = 0 | ||
| case InnerJoin: | ||
| // We will use right table as small table. |
There was a problem hiding this comment.
If right plan's count is smaller than the left one, we will treat right plan as small table.
coocood
reviewed
Apr 25, 2017
plan/task_profile.go
Outdated
| @@ -27,6 +27,7 @@ type taskProfile interface { | |||
| cost() float64 | |||
| copy() taskProfile | |||
| plan() PhysicalPlan | |||
| finishTask(ctx context.Context, allocator *idAllocator) taskProfile | |||
There was a problem hiding this comment.
The finishTask only make sense in copTaskProfile, promote it to taskProfile is confusing.
There was a problem hiding this comment.
finishCopTask makes more sense.
And add comment on it.
There was a problem hiding this comment.
Move it to a plain function is better, it makes the interface clean.
|
LGTM |
shenli
reviewed
Apr 25, 2017
| if cop, ok := profile.(*copTaskProfile); ok { | ||
| profile = cop.finishTask(p.ctx, p.allocator) | ||
| } | ||
| profile = finishCopTask(profile, p.ctx, p.allocator) |
There was a problem hiding this comment.
task checking is moved to finishCopTask
| @@ -378,7 +401,7 @@ func (p *PhysicalAggregation) attach2TaskProfile(profiles ...taskProfile) taskPr | |||
| cop.cnt = cop.cnt * aggFactor | |||
| } | |||
| } | |||
| profile = cop.finishTask(p.ctx, p.allocator) | |||
| profile = finishCopTask(cop, p.ctx, p.allocator) | |||
There was a problem hiding this comment.
needn't, finishCopTask will not change cop task.
|
LGTM |
shenli
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR let new plan support join. We only introduce hash join now, and in order to simplify problem, hash join will block any physical property.
@shenli @coocood @winoros @lamxTyler PTAL