Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: do not cache the tableDual plan #31290

Merged
merged 11 commits into from
Jan 5, 2022
Merged

planner: do not cache the tableDual plan #31290

merged 11 commits into from
Jan 5, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31280

Problem Summary:
Some tableDual will be cached previous.

What is changed and how it works?

Do not cache those tableDual plans.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent added type/bugfix This PR fixes a bug. sig/planner SIG: Planner epic/plan-cache needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 4, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/857b20607b4968a0a80793754126f0d1a4d5cf5b

@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0623243

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@Reminiscent
Copy link
Contributor Author

/merge

@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit 80527cb into pingcap:master Jan 5, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#31290 to release-5.3
69c86f0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31353

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 5, 2022
@Reminiscent @ti-srebot
cherry pick pingcap#31290 to release-5.4
5135d01 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31354

@Reminiscent Reminiscent deleted the issue#31280 branch January 6, 2022 03:57
ti-chi-bot pushed a commit that referenced this pull request Jan 6, 2022
@ti-srebot
planner: do not cache the tableDual plan (#31290) (#31354)
8889c7c 
close #31280
ti-chi-bot pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
planner: do not cache the tableDual plan (#31290) (#31353)
c002791 
close #31280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
epic/plan-cache needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cached tableDual operator
6 participants
@Reminiscent @ti-chi-bot @sre-bot @ti-srebot @qw4990 @Yisaer