executor: migrate test infra to testify for inspection_summary_test.go

executor/inspection_summary_test.go

@@ -16,62 +16,46 @@ package executor_test
 
 import (
 	"context"
+	"testing"
 
-	. "github.com/pingcap/check"
 	"github.com/pingcap/failpoint"
-	"github.com/pingcap/tidb/domain"
 	"github.com/pingcap/tidb/executor"
 	"github.com/pingcap/tidb/infoschema"
-	"github.com/pingcap/tidb/kv"
 	"github.com/pingcap/tidb/parser/mysql"
+	"github.com/pingcap/tidb/testkit"
 	"github.com/pingcap/tidb/types"
 	"github.com/pingcap/tidb/util/set"
-	"github.com/pingcap/tidb/util/testkit"
+	"github.com/stretchr/testify/require"
 )
 
-var _ = SerialSuites(&inspectionSummarySuite{})
 
-type inspectionSummarySuite struct {
-	store kv.Storage
-	dom   *domain.Domain
-}
-
-func (s *inspectionSummarySuite) SetUpSuite(c *C) {
-	store, dom, err := newStoreWithBootstrap()
-	c.Assert(err, IsNil)
-	s.store = store
-	s.dom = dom
-}
-
-func (s *inspectionSummarySuite) TearDownSuite(c *C) {
-	s.dom.Close()
-	s.store.Close()
-}
-
-func (s *inspectionSummarySuite) TestValidInspectionSummaryRules(c *C) {
+func TestValidInspectionSummaryRules(t *testing.T) {
 	for rule, tbls := range executor.InspectionSummaryRules {
 		tables := set.StringSet{}
-		for _, t := range tbls {
-			c.Assert(tables.Exist(t), IsFalse, Commentf("duplicate table name: %v in rule: %v", t, rule))
-			tables.Insert(t)
+		for _, tbl := range tbls {
+			require.False(t, tables.Exist(tbl), "duplicate table name: %v in rule: %v", tbl, rule)
+			tables.Insert(tbl)
 
-			_, found := infoschema.MetricTableMap[t]
-			c.Assert(found, IsTrue, Commentf("metric table %v not define", t))
+			_, found := infoschema.MetricTableMap[tbl]
+			require.True(t, found, "metric table %v not define", tbl)
 		}
 	}
 }
 
-func (s *inspectionSummarySuite) TestInspectionSummary(c *C) {
-	tk := testkit.NewTestKitWithInit(c, s.store)
+func TestInspectionSummary(t *testing.T) {
+	store, clean := testkit.CreateMockStore(t)
+	defer clean()
+
+	tk := testkit.NewTestKit(t, store)
 
 	fpName := "github.com/pingcap/tidb/executor/mockMetricsTableData"
-	c.Assert(failpoint.Enable(fpName, "return"), IsNil)
-	defer func() { c.Assert(failpoint.Disable(fpName), IsNil) }()
+	require.NoError(t, failpoint.Enable(fpName, "return"))
+	defer func() { require.NoError(t, failpoint.Disable(fpName)) }()
 
 	datetime := func(s string) types.Time {
-		t, err := types.ParseTime(tk.Se.GetSessionVars().StmtCtx, s, mysql.TypeDatetime, types.MaxFsp)
-		c.Assert(err, IsNil)
-		return t
+		time, err := types.ParseTime(tk.Session().GetSessionVars().StmtCtx, s, mysql.TypeDatetime, types.MaxFsp)
+		require.NoError(t, err)
+		return time
 	}
 
 	// construct some mock data
@@ -97,10 +81,10 @@ func (s *inspectionSummarySuite) TestInspectionSummary(c *C) {
 		return fpName == fpname
 	})
 
-	rs, err := tk.Se.Execute(ctx, "select * from information_schema.inspection_summary where rule='query-summary' and metrics_name in ('tidb_qps', 'tidb_query_duration')")
-	c.Assert(err, IsNil)
-	result := tk.ResultSetToResultWithCtx(ctx, rs[0], Commentf("execute inspect SQL failed"))
-	c.Assert(tk.Se.GetSessionVars().StmtCtx.WarningCount(), Equals, uint16(0), Commentf("unexpected warnings: %+v", tk.Se.GetSessionVars().StmtCtx.GetWarnings()))
+	rs, err := tk.Session().Execute(ctx, "select * from information_schema.inspection_summary where rule='query-summary' and metrics_name in ('tidb_qps', 'tidb_query_duration')")
+	require.NoError(t, err)
+	result := tk.ResultSetToResultWithCtx(ctx, rs[0], "execute inspect SQL failed")
+	require.Equal(t, uint16(0), tk.Session().GetSessionVars().StmtCtx.WarningCount(), "unexpected warnings: %+v", tk.Session().GetSessionVars().StmtCtx.GetWarnings())
 	result.Check(testkit.Rows(
 		"query-summary tikv-0 tidb_query_duration Select 0.99 0 0 0 The quantile of TiDB query durations(second)",
 		"query-summary tikv-1 tidb_query_duration Update 0.99 2 1 3 The quantile of TiDB query durations(second)",
@@ -111,10 +95,10 @@ func (s *inspectionSummarySuite) TestInspectionSummary(c *C) {
 	))
 
 	// Test for select * from information_schema.inspection_summary without specify rules.
-	rs, err = tk.Se.Execute(ctx, "select * from information_schema.inspection_summary where metrics_name = 'tidb_qps'")
-	c.Assert(err, IsNil)
-	result = tk.ResultSetToResultWithCtx(ctx, rs[0], Commentf("execute inspect SQL failed"))
-	c.Assert(tk.Se.GetSessionVars().StmtCtx.WarningCount(), Equals, uint16(0), Commentf("unexpected warnings: %+v", tk.Se.GetSessionVars().StmtCtx.GetWarnings()))
+	rs, err = tk.Session().Execute(ctx, "select * from information_schema.inspection_summary where metrics_name = 'tidb_qps'")
+	require.NoError(t, err)
+	result = tk.ResultSetToResultWithCtx(ctx, rs[0], "execute inspect SQL failed")
+	require.Equal(t, tk.Session().GetSessionVars().StmtCtx.WarningCount(), "unexpected warnings: %+v", tk.Session().GetSessionVars().StmtCtx.GetWarnings())
 	result.Check(testkit.Rows(
 		"query-summary tidb-0 tidb_qps Query, Error <nil> 1 1 1 TiDB query processing numbers per second",
 		"query-summary tidb-0 tidb_qps Query, OK <nil> 0 0 0 TiDB query processing numbers per second",