Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add more retryable error type #31484

Merged
merged 4 commits into from
Jan 10, 2022
Merged

lightning: add more retryable error type #31484

merged 4 commits into from
Jan 10, 2022

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Jan 10, 2022

What problem does this PR solve?

Issue Number: close #31376

Problem Summary:

What is changed and how it works?

Reference: retry check implementation in tidb-tools: https://github.com/pingcap/tidb-tools/blob/b1def7746ec382a71a70b8958b1053202092f95c/pkg/dbutil/retry.go#L43

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@glorv glorv added component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 10, 2022
@glorv glorv requested review from 3pointer and sleepymole January 10, 2022 01:45
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c44192d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 10, 2022

/run-integration-br-test

@glorv
Copy link
Contributor Author

glorv commented Jan 10, 2022

/run-check_dev

@sre-bot
Copy link
Contributor

sre-bot commented Jan 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6887d8f851d661c938007a246de9a7eb6d4ae052

@glorv
Copy link
Contributor Author

glorv commented Jan 10, 2022

/run-integration-br-test

@glorv
Copy link
Contributor Author

glorv commented Jan 10, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 0649ee8 into pingcap:master Jan 10, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 10, 2022
@glorv @ti-srebot
cherry pick pingcap#31484 to release-5.4
208eb2d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 10, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31505

@glorv glorv deleted the fix-conflict branch January 10, 2022 06:04
@glorv glorv added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Jan 10, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 10, 2022
@glorv @ti-srebot
cherry pick pingcap#31484 to release-5.3
f0168f3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 10, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31506

ti-chi-bot pushed a commit that referenced this pull request Jan 10, 2022
@ti-srebot
lightning: add more retryable error type (#31484) (#31505)
b84fef6 
close #31376
ti-chi-bot pushed a commit that referenced this pull request Feb 18, 2022
@ti-srebot
lightning: add more retryable error type (#31484) (#31506)
1eb9109 
close #31376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@glorv @ti-chi-bot @sre-bot @ti-srebot @3pointer @sleepymole