Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove direct placement in parser #31768

Merged
merged 11 commits into from
Jan 19, 2022
Merged

*: Remove direct placement in parser #31768

merged 11 commits into from
Jan 19, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #31485 #31424

Problem Summary:

Remove direct placement in parser

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Direct placement is not supported any more

@lcwangchao lcwangchao requested a review from a team as a code owner January 18, 2022 08:18
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 18, 2022
@lcwangchao lcwangchao linked an issue Jan 18, 2022 that may be closed by this pull request
Remove direct placement options from parser (table, partition, database schema context) #31424
Closed
@lcwangchao lcwangchao marked this pull request as draft January 18, 2022 08:29
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2
/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ff4b2f28743b8fc6e425ba337208d56bf8f62175

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@lcwangchao lcwangchao marked this pull request as ready for review January 18, 2022 12:15
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2022
@morgo
Copy link
Contributor

morgo commented Jan 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 666de94

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2022
@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2
/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 7fd298d into pingcap:master Jan 19, 2022
@lcwangchao lcwangchao deleted the remove_direct_placement_in_parser branch January 19, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@morgo morgo morgo approved these changes

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unit tests Remove direct placement options from parser (table, partition, database schema context)
5 participants
@lcwangchao @ti-chi-bot @sre-bot @morgo @hawkingrei