Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: handle collate for min/max(enum/set column) #31819

Merged
merged 4 commits into from
Jan 20, 2022
Merged

executor: handle collate for min/max(enum/set column) #31819

merged 4 commits into from
Jan 20, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jan 19, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #31638

Problem Summary:

What is changed and how it works?

handle collate for min/max(enum/set column)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
cd833e3 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2022
wshwsh12
wshwsh12 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 19, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ca34f5a6b141a8517fc2994e5c3f630a7178728d

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2022
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd833e3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@wjhuang2016
Copy link
Member Author

/run-mysql-test

@wjhuang2016
Copy link
Member Author

/run-unit-test

1 similar comment
@wjhuang2016
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e6812f9 into pingcap:master Jan 20, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31819 to release-4.0
cc8cdaf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #31855

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31819 to release-5.0
890e066 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #31856

@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #31857

@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31819 to release-5.2
30f61de 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #31858

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31819 to release-5.3
4157fce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31859

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#31819 to release-5.4
7483eb8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31860

bb7133 pushed a commit to ti-srebot/tidb that referenced this pull request Feb 7, 2022
@wjhuang2016 @bb7133
cherry pick pingcap#31819 to release-5.1
b55ea34 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Feb 10, 2022
@ti-srebot
executor: handle collate for min/max(enum/set column) (#31819) (#31857)
70e5da7 
close #31638
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
executor: handle collate for min/max(enum/set column) (#31819) (#31858)
47867bb 
close #31638
ti-chi-bot pushed a commit that referenced this pull request Apr 29, 2022
@ti-srebot
executor: handle collate for min/max(enum/set column) (#31819) (#31860)
382775c 
close #31638
ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot
executor: handle collate for min/max(enum/set column) (#31819) (#31859)
f329221 
close #31638
@wjhuang2016 wjhuang2016 deleted the fix_min_max_enum_set branch November 17, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doesn't handle collate for min/max(enum/set column)
6 participants
@wjhuang2016 @ti-chi-bot @sre-bot @ti-srebot @wshwsh12 @ichn-hu