Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: update doc links to tidb repo #31944

Merged
merged 3 commits into from
Jan 25, 2022
Merged

parser: update doc links to tidb repo #31944

merged 3 commits into from
Jan 25, 2022

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Jan 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #28257

Problem Summary:

The parser has been merged into TiDB repo since v5.3.0. However, some links still point to the parser repo. I think we should update these links to TiDB repo.

What is changed and how it works?

Update doc links and remove redundant https://github.com/pingcap/tidb/blob/master/parser/docs/update-parser-for-tidb.md.
Rendered Readme and quickstart.md.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2022
@sleepymole
Copy link
Contributor Author

/cc @xhebox

xhebox
xhebox approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2022
@xhebox
Copy link
Contributor

xhebox commented Jan 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9eca0b4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@sleepymole
Copy link
Contributor Author

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 25, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/eea675ddb489b3b356fe1f87d60a691dbbb056ca

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit fa49483 into pingcap:master Jan 25, 2022
@sleepymole sleepymole deleted the link branch January 25, 2022 07:19
dveeden added a commit to dveeden/tidb-dev-guide that referenced this pull request Jan 19, 2023
@dveeden
parser: Remove old doc reference
14df058 
See also: pingcap/tidb#31944
@dveeden dveeden mentioned this pull request Jan 19, 2023
Merged
zhangyangyu pushed a commit to pingcap/tidb-dev-guide that referenced this pull request Jan 20, 2023
@dveeden
parser: Remove old doc reference (#224)
dc8211d 
See also: pingcap/tidb#31944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sleepymole @ti-chi-bot @xhebox @hawkingrei @sre-bot @Defined2014