Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, ddl: convert large varchar for create table in non-strict mode #31974

Merged
merged 11 commits into from
Mar 2, 2022
Merged

planner, ddl: convert large varchar for create table in non-strict mode #31974

merged 11 commits into from
Mar 2, 2022

Conversation

unconsolable
Copy link
Contributor

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

What problem does this PR solve?

Issue Number: close #30328

Problem Summary:

What is changed and how it works?

  • In non strict mode, auto convert varchar with large length to TEXT or BLOB, and append warnings.
  • Fix a nil pointer dereference in test case due to changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@unconsolable
planner, ddl: convert large varchar for create table in non-strict mode
325a790 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@unconsolable
planner: fix lint
4d967d2 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot requested review from djshow832 and sylzd January 26, 2022 04:51
djshow832
djshow832 reviewed Jan 26, 2022
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
planner/core/preprocess_test.go Outdated Show resolved Hide resolved
@djshow832 djshow832 requested a review from morgo January 26, 2022 08:30
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2022
@unconsolable
ddl: fix and test for alter table stmt
7754e12 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 26, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/35bb8d83912e0371eb9c917483a714cb436b065e

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2022
@unconsolable
go fmt
1c0400e 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2022
@unconsolable
planner/core: migrate test to testify
bc9577a 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
djshow832
djshow832 reviewed Feb 24, 2022
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

planner/core/preprocess_test.go Outdated Show resolved Hide resolved
@unconsolable
remove sql_mode and warning restore
a515b05 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2022
zimulala
zimulala reviewed Feb 24, 2022
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
planner/core/preprocess.go Show resolved Hide resolved
zimulala
zimulala reviewed Feb 24, 2022
View reviewed changes
planner/core/preprocess.go Outdated Show resolved Hide resolved
planner/core/preprocess.go Outdated Show resolved Hide resolved
@zimulala zimulala added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Feb 24, 2022
@unconsolable
adopt reviewer's comments
c8f6852 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
zimulala
zimulala approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@zimulala
Copy link
Contributor

zimulala commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8f6852

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@ti-chi-bot
Copy link
Member

@unconsolable: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a350290 into pingcap:master Mar 2, 2022
@unconsolable unconsolable deleted the issue-31372 branch March 2, 2022 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

@zimulala zimulala zimulala approved these changes

@morgo morgo Awaiting requested review from morgo

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
5 participants
@unconsolable @ti-chi-bot @sre-bot @zimulala @djshow832