Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix alter column set default wrongly updates the schema #32249

Merged
merged 4 commits into from
Feb 11, 2022
Merged

ddl: fix alter column set default wrongly updates the schema #32249

merged 4 commits into from
Feb 11, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Feb 11, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

What problem does this PR solve?

Issue Number: close #31074

Problem Summary:
Should use the new column to update the default, not in place.

What is changed and how it works?

clone the old column.

Check List

Tests

  • Unit test
  • Integration test
    This case is covered by schrddl.
  • Manual test (add detailed scripts or steps below)
    Modify code to sleep before adding the job into the queue, and check if its default is changed.
create table gf(a int);
alter table gf alter column  a set default 13;
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix `alter column set default` wrongly updates the schema

@wjhuang2016
done
d6d1b65 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 11, 2022
wjhuang2016 and others added 2 commits February 11, 2022 13:33
@wjhuang2016
fix test
821c842 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@hawkingrei
Merge branch 'master' into fix_set_default_ddl
e55031c
@sre-bot
Copy link
Contributor

sre-bot commented Feb 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2cbcd2a05b36ff3d50ac5dbddd32b0402d0c4b34

@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e55031c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 11, 2022
@ti-chi-bot ti-chi-bot merged commit 6d2ad99 into pingcap:master Feb 11, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 11, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#32249 to release-4.0
7116432 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32259

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 11, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#32249 to release-5.0
3c289af 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32261

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 11, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#32249 to release-5.1
5902bdf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32262

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 11, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#32249 to release-5.2
da0c06f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32263

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 11, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#32249 to release-5.3
2e227ac 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32264

BornChanger
BornChanger reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ti-chi-bot pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
ddl: fix alter column set default wrongly updates the schema (#32249)…
840c6a4 
… (#32264)

close #31074
@wjhuang2016 wjhuang2016 deleted the fix_set_default_ddl branch November 17, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger left review comments

@Defined2014 Defined2014 Defined2014 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alter column set default wrongly modify information_schema
7 participants
@wjhuang2016 @ti-chi-bot @sre-bot @ti-srebot @hawkingrei @Defined2014 @BornChanger