-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the usage of ParamMaker in BatchPointGet #32534
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5e9370508791a2fb29a48f14addefe3c46390a44 |
We triggered Plan Cache PointGet Random Testing again and no regression was found. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cf1793f
|
What problem does this PR solve?
Issue Number: ref #31056
Problem Summary: planner: fix the usage of ParamMaker in BatchPointGet
What is changed and how it works?
The following PR of #32235, no logical change, just refactor that replacing
ParamMaker
withConstant
inBatchPointGet
to make it safer.Check List
Tests
Side effects
Documentation
Release note