Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix tidb can point update data even if tidb_super_read_only is on #32547

Merged
merged 2 commits into from
Feb 23, 2022
Merged

planner: fix tidb can point update data even if tidb_super_read_only is on #32547

merged 2 commits into from
Feb 23, 2022

Conversation

ichn-hu
Copy link
Contributor

@ichn-hu ichn-hu commented Feb 23, 2022

What problem does this PR solve?

Issue Number: close #32539

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@ichn-hu
Copy link
Contributor Author

ichn-hu commented Feb 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7afc65f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Feb 23, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7afc65f803ad04ea6ddaa5d12c12262074efab8e

@ti-chi-bot ti-chi-bot merged commit 221801b into pingcap:master Feb 23, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ichn-hu @ti-srebot
cherry pick pingcap#32547 to release-5.2
0177928 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32550

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ichn-hu @ti-srebot
cherry pick pingcap#32547 to release-5.3
d675a01 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32551

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 23, 2022
@ichn-hu @ti-srebot
cherry pick pingcap#32547 to release-5.4
11d0d1c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 23, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32552

zhouqiang-cl pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
planner: fix tidb can point update data even if tidb_super_read_only …
1ee4efe 
…is on (#32547) (#32552)

* cherry pick #32547 to release-5.4

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot pushed a commit that referenced this pull request Feb 23, 2022
@ti-srebot
planner: fix tidb can point update data even if tidb_super_read_only …
5d6aa4e 
…is on (#32547) (#32551)

close #32539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb can point update data even if tidb_super_read_only is on
7 participants
@ichn-hu @ti-chi-bot @hawkingrei @sre-bot @ti-srebot @guo-shaoge @wshwsh12