-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner,executor: fix cached table query with filter condition #32590
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/rebuild |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c2a28e663d7ff4752516359a2d43f4da6fd4d593 |
@tiancaiamao: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 93331c8
|
/run-unit-test |
/run-mysql-test |
What problem does this PR solve?
Issue Number: close #32422
Problem Summary:
This bug was introduced by #32139
In the initial implementation, I generate UnionScan plan when reading from cache, and no UnionScan when the cache is bypassed or unavailable.
But since the shape of the plan is different, the prepared plan cache feature is not applicable.
Then, #32139 try to fix the prepare plan cache issue by defer the UnionScanExec generation to the executor build phase. It did make plan cache possible, but introduce bug #32422
Handling the filter condition is not a trivial work if we continue generating UnionScanExec in the executor build phase:
Some are pushed down to TableReader and some remains, cause it's difficult to rebuild the filter condition for UnionScan in the executor build phase.
What is changed and how it works?
So I change the implementation the third time.
This time, I will always keep the UnionScan in the planner phase for a cached table, and whether the UnionScan is really used is decided by whether the cached data is available.
In this way, prepared plan cache is applicable, since the shape of plan is unchanged (although maybe less efficient in some minor cases), and also the filter condition bug is fixed.
Check List
Tests
Side effects
Documentation
Release note