-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: migrate test-infra to testify for chunk_size_control #32616
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
CI failed exactly on the changed tests. |
And I just notice that the test has been skipped originally. |
/run-all-tests |
9842971
to
7ec63ea
Compare
@hawkingrei I tend to migrate the test first and file another issue to remove |
OK, I have added |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c6f0f65246d28b88e8ef928c2dad62a4e55dc890 |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1382e87
|
@hawkingrei: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #28569
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note