-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: migrate test-infra to testify for simple_test #32650
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
2fc7dc6
to
78e4dea
Compare
/merge Although some lines like: _, err = tk.Exec(...)
require.NoError(t , err)
// or
_, err = tk.Exec(...)
require.Error(t , err) can be simplify as: tk.MustExec(...)
// and
require.Error(tk.ExecToErr(...)) They're not a blocker for migration. |
This pull request has been accepted and is ready to merge. Commit hash: 78e4dea52fc7216f694937ff0b7b4b192924c17f
|
It has some problem in test to fix. |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
7379507
to
14f7806
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 14f7806
|
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cd9f909c8ab8cbfa876a97ea683dd0b4b4f4cb06 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: cd9f909
|
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #28614
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note