Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br-stream: add region context in applyRequest #32657

Merged
merged 6 commits into from
Mar 4, 2022
Merged

br-stream: add region context in applyRequest #32657

merged 6 commits into from
Mar 4, 2022

Conversation

3pointer
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31975

Problem Summary:
apply kv files to tikv cluster.

What is changed and how it works?

use raft router to apply kv files instead of kv engine.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • joccau

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 28, 2022
@3pointer 3pointer requested a review from YuJuncen February 28, 2022 03:26
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 28, 2022
@3pointer 3pointer requested review from kennytm, eurekaka and joccau and removed request for eurekaka February 28, 2022 03:26
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2022
joccau
joccau approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for rest

br/pkg/restore/split.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 3, 2022
@3pointer @joccau
Update br/pkg/restore/split.go
8654b9b 
Co-authored-by: Zak Zhao <57036248+joccau@users.noreply.github.com>
@3pointer
Copy link
Contributor Author

3pointer commented Mar 3, 2022

/run-integration-br-test

@kennytm
Copy link
Contributor

kennytm commented Mar 3, 2022

/run-check_dev

@3pointer 3pointer merged commit d282456 into pingcap:br-stream Mar 4, 2022
3pointer added a commit to 3pointer/tidb that referenced this pull request Mar 9, 2022
@3pointer
br-stream: add region context in applyRequest (pingcap#32657)
5fbe645 
* br-stream: add region context in applyRequest
3pointer added a commit that referenced this pull request Mar 21, 2022
@3pointer
br-stream: add region context in applyRequest (#32657)
e7174fb 
* br-stream: add region context in applyRequest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joccau joccau joccau approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3pointer @ti-chi-bot @kennytm @YuJuncen @joccau