Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for parallel_apply_test.go #32686

Merged
merged 9 commits into from
Mar 2, 2022
Merged

executor: migrate test-infra to testify for parallel_apply_test.go #32686

merged 9 commits into from
Mar 2, 2022

Conversation

feitian124
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28599

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1d2e0cb6e3ebe3acfafbc8fa6ffa4b4e3c381c74

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@hawkingrei
Copy link
Member

/cc @tisonkun

@ti-chi-bot ti-chi-bot requested a review from tisonkun March 1, 2022 06:08
@hawkingrei hawkingrei requested a review from wshwsh12 March 1, 2022 06:12
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
tisonkun
tisonkun requested changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NewTestKitWithInit is somehow too much to encapsulate and I intend to avoid it but with one more line tk.MustExec("use test")

Most developers aren't aware difference between NewTestKitWithInit and NewTestKit but choose either randomly (what is "Init"?). I think make it explicit should help.

testkit/testkit.go Outdated
Comment on lines 76 to 81
// NewTestKitWithInit returns a new *TestKit and use test db.
func NewTestKitWithInit(t testing.TB, store kv.Storage) *TestKit {
tk := NewTestKit(t, store)
tk.MustExec("use test")
return tk
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this method.

@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Mar 1, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Mar 1, 2022 •
edited
Loading

/merge cancel

@tisonkun tisonkun removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Mar 1, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Mar 1, 2022

/cc @hawkingrei @xiongjiwei

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@tisonkun
Copy link
Contributor

tisonkun commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 205ed9d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@feitian124
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@feitian124: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1e1cf22 into pingcap:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@tisonkun tisonkun tisonkun approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for parallel_apply_test.go
6 participants
@feitian124 @ti-chi-bot @sre-bot @hawkingrei @xiongjiwei @tisonkun