Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: use pd timestamp to update gc safepoint #32734

Merged
merged 5 commits into from
Mar 3, 2022
Merged

lightning: use pd timestamp to update gc safepoint #32734

merged 5 commits into from
Mar 3, 2022

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Mar 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #32733

Problem Summary:

Lightning uses the local unix timestamp to update service gc safepoint. However, local clock is not reliable. If the start ts of checksum transaction is smaller than the local ts, lightning may encounter “GC life time is shorter than transaction duration” error during doing checksum.

What is changed and how it works?

Always use PD timestamp to update service gc safepoint.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

lightning: fix checksum encountered “GC life time is shorter than transaction duration” error

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 2, 2022
@sleepymole sleepymole marked this pull request as ready for review March 2, 2022 08:12
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2022
@sleepymole
Copy link
Contributor Author

/component lightning
/cc @glorv @kennytm

@ti-chi-bot ti-chi-bot requested review from glorv and kennytm March 2, 2022 08:15
@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Mar 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1e4ceb4069db4439ad2c903a0f4549869b596ac3

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Mar 3, 2022
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 3, 2022
@glorv
Copy link
Contributor

glorv commented Mar 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ef03a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 3, 2022
@ti-chi-bot ti-chi-bot merged commit 5288efa into pingcap:master Mar 3, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32734 to release-5.2
db6ee31 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32797

@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32798

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32734 to release-5.3
a857e8c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 3, 2022
@sleepymole @ti-srebot
cherry pick pingcap#32734 to release-5.4
848f484 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 3, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32799

@sleepymole sleepymole deleted the issue-32733 branch March 22, 2022 11:39
ti-chi-bot pushed a commit that referenced this pull request Apr 14, 2022
@ti-srebot
lightning: use pd timestamp to update gc safepoint (#32734) (#32797)
d4ea430 
close #32733
ti-chi-bot pushed a commit that referenced this pull request Apr 21, 2022
@ti-srebot
lightning: use pd timestamp to update gc safepoint (#32734) (#32799)
036ab62 
close #32733
ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2022
@ti-srebot
lightning: use pd timestamp to update gc safepoint (#32734) (#32798)
2dee0e6 
close #32733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: checksum encountered “GC life time is shorter than transaction duration” error
6 participants
@sleepymole @ti-chi-bot @sre-bot @glorv @ti-srebot @kennytm