Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: migrate test-infra to testify for memtable_reader_test.go #32735

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Mar 2, 2022

What problem does this PR solve?

Issue Number: close #28596

None

tisonkun added 2 commits March 2, 2022 12:19
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 2, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

/cc @hawkingrei @tangenta @lonng

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2022
@hawkingrei
Copy link
Member

hawkingrei commented Mar 2, 2022

@tisonkun Please fix the linter.

[2022-03-02T04:41:35.590Z] executor/executor_test.go:166:6: `newStoreWithBootstrap` is unused (deadcode)

[2022-03-02T04:41:35.590Z] func newStoreWithBootstrap() (kv.Storage, *domain.Domain, error) {

@sre-bot
Copy link
Contributor

sre-bot commented Mar 2, 2022

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

@hawkingrei fixed.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@xhebox
Copy link
Contributor

xhebox commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c468d04

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit edb900e into pingcap:master Mar 2, 2022
@tisonkun tisonkun deleted the issue-28596 branch March 2, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for memtable_reader_test.go
5 participants