Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash (#32813) #32838

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 4, 2022

cherry-pick #32813 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32838

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32838:release-5.1-fcdbf826ea8a

What problem does this PR solve?

Issue Number: close #32814, pingcap/tiflash#4163

Problem Summary:

  1. if a fragment has two children, one's ExchangeSender is Broadcast Type, another's is Type PassThrough.
  2. This fragment should be singleton, but because of the wrong implementation, it isn't.
  3. So this fragment will generate two tasks, and the data will be double.

What is changed and how it works?

if there is one child with passthrough exchangeType, the fragment will be singleton.

Check List

Tests

  • Unit test

Release note

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 4, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 4, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.1-cherry-pick labels Mar 4, 2022
@ti-chi-bot ti-chi-bot removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2022
@ti-srebot ti-srebot requested review from fzhedu and windtalker March 4, 2022 09:45
@ti-srebot ti-srebot added this to the v5.1.4 milestone Mar 4, 2022
@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
@VelocityLight
Copy link

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants