Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash (#32813) #32841

Merged
merged 8 commits into from
Apr 27, 2022
Merged

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash (#32813) #32841

merged 8 commits into from
Apr 27, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 4, 2022 •
edited
Loading

cherry-pick #32813 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32841

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32841:release-5.4-fcdbf826ea8a

What problem does this PR solve?

Issue Number: close #32814, pingcap/tiflash#4163

Problem Summary:

  1. if a fragment has two children, one's ExchangeSender is Broadcast Type, another's is Type PassThrough.
  2. This fragment should be singleton, but because of the wrong implementation, it isn't.
  3. So this fragment will generate two tasks, and the data will be double.

What is changed and how it works?

if there is one child with passthrough exchangeType, the fragment will be singleton.

Check List

Tests

  • Unit test

Release note

planner: Fix the issue that TiDB may dispatch duplicated tasks to TiFlash

@LittleFall @ti-srebot
cherry pick pingcap#32813 to release-5.4
c635780 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 4, 2022
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.4-cherry-pick labels Mar 4, 2022
@ti-srebot ti-srebot mentioned this pull request Mar 4, 2022
Merged
1 task
@ti-srebot ti-srebot requested review from fzhedu and windtalker March 4, 2022 09:50
@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 11, 2022
windtalker
windtalker approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ba47a37834be0da49c31f0ebf08110ec6ab693d3

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 24, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 49d0952

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@purelind
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 9687ea4 into pingcap:release-5.4 Apr 27, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@windtalker windtalker windtalker approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees

@LittleFall LittleFall

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @sre-bot @tiancaiamao @purelind @windtalker @LittleFall @VelocityLight