-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix wrong result of delete multiple tables using left join (#33055) #33119
executor: fix wrong result of delete multiple tables using left join (#33055) #33119
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@guo-shaoge you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7c5efff
|
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f0aea347b438c667e714891c884bef15effbc9de |
/run-mysql-test |
/run-mysql-test |
1 similar comment
/run-mysql-test |
cherry-pick #33055 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33119
After apply modifications, you can push your change to this PR via:
Signed-off-by: guo-shaoge shaoge1994@163.com
What problem does this PR solve?
Issue Number: close #31321
Problem Summary:
delete from t1, t2 using t1 left join t2 on t1.c1 = t2.c1;
row of t1: (1)
row of t2: (2)
The join result will be
(1, null)
.1
in t1 is matched, and no row in t2 is matched. So row in t1 should be deleted, while no row in t2 should be deleted.But the original implementation didn't check if the row in t2 is matched or not, just delete it directly, which cause the wrong result.
What is changed and how it works?
If a row is not matched in outer join, the rowid of the join result will be NULL, we use this to decide if we can delete row.
Check List
Tests
Side effects
Documentation
Release note