Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add doc of functional dependency #33164

Closed
wants to merge 12 commits into from
Closed

doc: add doc of functional dependency #33164

wants to merge 12 commits into from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Mar 16, 2022 •
edited
Loading

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #29766

Problem Summary:

What is changed and how it works?

Motivation Issue: #29766
add doc of functional dependency

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@AilinKid
add fd doc
a20d35f 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
fmt
614767c 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
fmt
5aee7af 
Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2022
@AilinKid
fmt
1a7293f 
Signed-off-by: ailinkid <314806019@qq.com>
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/581536b32366972974523d063df2d80c7c0c489e

time-and-fate
time-and-fate reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please replace "function dependency" with "functional dependency".

docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated
```sql
create table t1(a int, c int)
create table t2(a int, b int)
select t1.a from t1 join t2 on t2.a=t1.a group by t2.a where c=1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this SQL? It's different from the below one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahaaa, a mistake, >.<

docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
docs/design/2022-03-16-functional-dependency.md Outdated Show resolved Hide resolved
make fmt
55393ee 
Signed-off-by: arenatlx <arenatlx@arenatlxdeMacBook-Pro.local>
@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ hawkingrei
✅ AilinKid
❌ arenatlx

arenatlx seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

fix the FD name as functional dependency
581536b 
Signed-off-by: arenatlx <arenatlx@arenatlxdeMacBook-Pro.local>
@AilinKid
Copy link
Contributor Author

some CLA problem occurs when migrating to my new pc. Resolved by redirecting to #33875

@AilinKid AilinKid closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate left review comments

@winoros winoros Awaiting requested review from winoros

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine only-full-group-by checker
6 participants
@AilinKid @ti-chi-bot @sre-bot @CLAassistant @time-and-fate @hawkingrei