Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: lower innodb-lock-wait-timeout MaxValue to match max-txn-ttl #33473

Merged
merged 2 commits into from
Mar 26, 2022

Conversation

Alkaagr81
Copy link
Collaborator

@Alkaagr81 Alkaagr81 commented Mar 25, 2022

What problem does this PR solve?

Issue Number: close #33472

Problem Summary: innodb_lock_wait_timeout can exceed max-txn-ttl

What is changed and how it works?

The Innodb-Lock-Wait-Timeout max value is changed to 3600 which converts to 3600000 MS, the same as max-txn-ttl default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility
    Minimal change to MySQL compatibility: most users don't change this setting, and setting it to a larger value results in a warning + truncation, not an error.

Release note

The maximum value for the system variable innodb_lock_wait_timeout has been lowered to 3600 seconds. This matches the max-txn-ttl.

@Alkaagr81 Alkaagr81 requested a review from a team as a code owner March 25, 2022 20:55
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 25, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@Alkaagr81 Alkaagr81 changed the title Changes done for innodb-lock-wait-timeout max value change Session: Changes done for innodb-lock-wait-timeout max value change Mar 25, 2022
@Alkaagr81
Copy link
Collaborator Author

/run-check_title

@Alkaagr81
Copy link
Collaborator Author

/cc @morgo

@ti-chi-bot ti-chi-bot requested a review from morgo March 25, 2022 21:09
@morgo morgo changed the title Session: Changes done for innodb-lock-wait-timeout max value change session: lower innodb-lock-wait-timeout MaxValue to match max-txn-ttl Mar 25, 2022
@morgo
Copy link
Contributor

morgo commented Mar 25, 2022

/run-unit-test

Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2022
@ngaut
Copy link
Member

ngaut commented Mar 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ac41f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2022
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot
Copy link
Member

@Alkaagr81: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-mysql-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 26, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

innodb_lock_wait_timeout MaxValue > max-txn-ttl
6 participants