Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix execute failed when table schema changed #33519

Merged
merged 3 commits into from
Mar 30, 2022
Merged

executor: fix execute failed when table schema changed #33519

merged 3 commits into from
Mar 30, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #33509

Problem Summary:

What is changed and how it works?

revert some changes in #12388 that will cause some panic

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

resultSet's columns cache is disabled for different query that will cause a tiny performance down.

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix bug #33509

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Mar 28, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2022
cfzjywxk
cfzjywxk approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the bench bot to verify if there's regression risk.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@lcwangchao
Copy link
Collaborator Author

/run-unit-test
/run-mysql-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b55685523b2753a87047539d520bbe1b256d1e62

tiancaiamao
tiancaiamao approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do we have a schema version together with the ColumnInfo so we can still reuse the objects and at the same time avoid the bug?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2022
@lcwangchao
Copy link
Collaborator Author

LGTM

Do we have a schema version together with the ColumnInfo so we can still reuse the objects and at the same time avoid the bug?

I did not found it. Theoretically yes, we can add it but it will be more complicated and may cause some potential bugs

@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b556855

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2022
@ti-chi-bot ti-chi-bot merged commit 5004a81 into pingcap:master Mar 30, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-4.0
71ae990 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33572

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-5.0
6b9d87b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33573

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-5.1
46c67bc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33574

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-5.2
a0bd088 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33575

@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-5.3
67fd7ef 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33576

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-5.4
a9737c7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33577

@ti-srebot ti-srebot mentioned this pull request Mar 30, 2022
Closed
9 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33519 to release-6.0
3cb3127 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33578

@lcwangchao lcwangchao deleted the fix_33509 branch March 30, 2022 02:52
ti-chi-bot pushed a commit that referenced this pull request Apr 24, 2022
@ti-srebot
executor: fix execute failed when table schema changed (#33519) (#33577)
4001a16 
close #33509
lcwangchao added a commit to lcwangchao/tidb that referenced this pull request May 6, 2022
@lcwangchao
Revert "executor: fix execute failed when table schema changed (pingc…
921170c 
…ap#33519) (pingcap#33577)"

This reverts commit 4001a16.
@lcwangchao lcwangchao mentioned this pull request May 6, 2022
Closed
lcwangchao added a commit to lcwangchao/tidb that referenced this pull request May 6, 2022
@lcwangchao
*: Revert pingcap#33519 for performance fallback and fix the pingcap#…
9e071a0 
…33509 in another way

This reverts commit 5004a81.
ti-chi-bot pushed a commit that referenced this pull request May 6, 2022
@lcwangchao
*: Revert #33519 for performance fallback and fix the #33509 in anoth…
1f9d34a 
…er way (#34425)

close #33509
ti-chi-bot pushed a commit that referenced this pull request May 6, 2022
@ti-srebot
*: Revert #33519 for performance fallback and fix the #33509 in anoth…
f604940 
…er way (#34425) (#34433)

close #33509
ti-chi-bot pushed a commit that referenced this pull request Jun 15, 2022
@ti-srebot
*: Revert #33519 for performance fallback and fix the #33509 in anoth…
d4f1d2d 
…er way (#34425) (#34432)

close #33509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execute prepared statement with binary protocol will panic when table schema changed
6 participants
@lcwangchao @ti-chi-bot @sre-bot @ti-srebot @tiancaiamao @cfzjywxk