Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: fix invalid transaction error when doing stale read in RC isolation level #33653

Merged
merged 3 commits into from
Apr 2, 2022
Merged

txn: fix invalid transaction error when doing stale read in RC isolation level #33653

merged 3 commits into from
Apr 2, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #30872

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix `invalid transaction` error when doing stale read in RC isolation level

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-6.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9534349385e08c50b29a2e22b3c8541478c80ec0

MyonKeminta
MyonKeminta reviewed Apr 1, 2022
View reviewed changes
executor/builder.go
@@ -122,6 +122,7 @@ func newExecutorBuilder(ctx sessionctx.Context, is infoschema.InfoSchema, ti *Te
ctx: ctx,
is: is,
Ti: ti,
snapshotTSCached: isStaleness,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand. Where is the snapshotTS set in this case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for stale read snapshotTS is set when executorBuilder is constructed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just under this line

@lcwangchao
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@lcwangchao lcwangchao requested a review from xhebox April 2, 2022 01:49
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@xhebox
Copy link
Contributor

xhebox commented Apr 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ba0f09

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot ti-chi-bot merged commit ec63787 into pingcap:master Apr 2, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33653 to release-5.4
dfadd62 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33662

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 2, 2022
@lcwangchao @ti-srebot
cherry pick pingcap#33653 to release-6.0
7dd9c25 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 2, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33663

@lcwangchao lcwangchao deleted the fix_30872 branch April 2, 2022 03:59
ti-chi-bot pushed a commit that referenced this pull request Aug 2, 2022
@ti-srebot
txn: fix invalid transaction error when doing stale read in RC isol…
db22b01 
…ation level (#33653) (#33662)

close #30872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta left review comments

@Yisaer Yisaer Yisaer approved these changes

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stale read failed for read-committed isolation when autocommit=0
7 participants
@lcwangchao @ti-chi-bot @sre-bot @xhebox @ti-srebot @MyonKeminta @Yisaer